gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py#107971
Merged
iritkatriel merged 18 commits intopython:mainfrom Aug 16, 2023
Merged
gh-105481: generate op IDs from bytecode.c instead of hard coding them in opcode.py#107971iritkatriel merged 18 commits intopython:mainfrom
iritkatriel merged 18 commits intopython:mainfrom
Conversation
…de_Deopt as part of metadata
…codes map in dis.
iritkatriel
requested review from
brettcannon,
ericsnowcurrently,
markshannon,
ncoghlan and
warsaw
as code owners
ericsnowcurrently
approved these changes
Aug 15, 2023
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Mostly LGTM. I've left a couple comments where there might be something further to be done.
(I'm approving under the assumption the comments will be resolved first, one way or another.)
Member
Author
Thanks. A couple of tests for tracing/instrumentation are failing, I'm still debugging that. |
… instrumented opcode (python#107978)
gvanrossum
approved these changes
Aug 16, 2023
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
The revolution! It's almost here!!
A few nits but no need to wait for a re-review.
| @@ -1617,197 +1616,197 @@ def _prepare_test_cases(): | |||
| Instruction = dis.Instruction | |||
|
|
|||
| expected_opinfo_outer = [ | |||
Member
There was a problem hiding this comment.
This test is just preposterous. Let's commit to doing this in a different way in a future PR.
gvanrossum
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.