gh-107614: Normalise Argument Clinic error messages#107615
Merged
erlend-aasland merged 10 commits intopython:mainfrom Aug 4, 2023
Merged
gh-107614: Normalise Argument Clinic error messages#107615erlend-aasland merged 10 commits intopython:mainfrom
erlend-aasland merged 10 commits intopython:mainfrom
Conversation
- always wrap the offending line, token, or name in quotes - always put the entire error message on one line
Contributor
Author
|
Depends on gh-107611 (or the other way around; either way, we'll have conflicts) |
erlend-aasland
commented
Aug 4, 2023
AlexWaygood
reviewed
Aug 4, 2023
AlexWaygood
reviewed
Aug 4, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Some suggestions to keep line lengths below 90, where reasonable:
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Contributor
Author
Thanks; applied! |
AlexWaygood
reviewed
Aug 4, 2023
AlexWaygood
reviewed
Aug 4, 2023
AlexWaygood
reviewed
Aug 4, 2023
AlexWaygood
reviewed
Aug 4, 2023
AlexWaygood
approved these changes
Aug 4, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Contributor
Author
Thanks for the helpful review and suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.