Skip to content

gh-104090: Fix unittest collectedDurations resources leak#106795

Merged
iritkatriel merged 4 commits intopython:mainfrom
bityob:gh-104090-fix-leaked-semaphors-on-test_concurrent_futures
Jul 19, 2023
Merged

gh-104090: Fix unittest collectedDurations resources leak#106795
iritkatriel merged 4 commits intopython:mainfrom
bityob:gh-104090-fix-leaked-semaphors-on-test_concurrent_futures

Conversation

@bityob
Copy link
Contributor

@bityob bityob commented Jul 15, 2023 •
edited
Loading

  1. Fixed TestResult.addDuration method to add only test repr string and not the test object itself, to avoid resources leak

@iritkatriel

@bedevere-bot
Copy link

bedevere-bot commented Jul 15, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot mentioned this pull request Jul 15, 2023
Open
@bityob bityob force-pushed the gh-104090-fix-leaked-semaphors-on-test_concurrent_futures branch from cdbe1c4 to 8cd162f Compare July 16, 2023 08:53
@iritkatriel
Copy link
Member

iritkatriel commented Jul 16, 2023

I think it might be better to split this into two PRs (attached to the same issue), one for the unittest fix and the other for the resource tracker change.

@bityob bityob force-pushed the gh-104090-fix-leaked-semaphors-on-test_concurrent_futures branch from 5585599 to 509636a Compare July 16, 2023 11:58
@bedevere-bot
Copy link

bedevere-bot commented Jul 16, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bityob
Copy link
Contributor Author

bityob commented Jul 16, 2023

I think it might be better to split this into two PRs (attached to the same issue), one for the unittest fix and the other for the resource tracker change.

Done

Second PR: #106807

@iritkatriel iritkatriel added tests Tests in the Lib/test dir stdlib Standard Library Python modules in the Lib/ directory labels Jul 16, 2023
@iritkatriel
Copy link
Member

iritkatriel commented Jul 16, 2023

CC unittest maintainers. @gpshead @ezio-melotti

See issue for motivation.

@iritkatriel
Copy link
Member

iritkatriel commented Jul 17, 2023

@giampaolo addDuration was added in 3.12. Should this be backported as a bugfix?

@iritkatriel iritkatriel requested a review from giampaolo July 17, 2023 15:10
@sunmy2019
Copy link
Member

sunmy2019 commented Jul 18, 2023

Is this new entry necessary?

Should this be backported as a bugfix?

+1 from me

@sunmy2019 sunmy2019 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 18, 2023
@bedevere-bot
Copy link

bedevere-bot commented Jul 18, 2023

🤖 New build scheduled with the buildbot fleet by @sunmy2019 for commit d493239 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 18, 2023
@iritkatriel iritkatriel added the needs backport to 3.12 only security fixes label Jul 18, 2023
@sunmy2019 sunmy2019 mentioned this pull request Jul 19, 2023
Closed
@giampaolo
Copy link
Contributor

giampaolo commented Jul 19, 2023 •
edited
Loading

@iritkatriel wrote:

@giampaolo addDuration was added in 3.12. Should this be backported as a bugfix?

Hi! Yes, I think it should be backported.

@iritkatriel iritkatriel merged commit 70b961e into python:main Jul 19, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 19, 2023

Thanks @bityob for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 19, 2023

GH-106888 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 19, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2023
@bityob @miss-islington
pythongh-104090: Fix unittest collectedDurations resources leak (pyth…
8b1fdec 
…onGH-106795)

(cherry picked from commit 70b961e)

Co-authored-by: Yonatan Bitton <[email protected]>
@iritkatriel iritkatriel added the needs backport to 3.12 only security fixes label Jul 19, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 19, 2023

Thanks @bityob for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2023
@bityob @miss-islington
pythongh-104090: Fix unittest collectedDurations resources leak (pyth…
e0a4576 
…onGH-106795)

(cherry picked from commit 70b961e)

Co-authored-by: Yonatan Bitton <[email protected]>
iritkatriel pushed a commit that referenced this pull request Jul 19, 2023
@miss-islington @bityob
[3.12] gh-104090: Fix unittest collectedDurations resources leak (GH-…
b1c50b8 
…106795) (#106888)

gh-104090: Fix unittest collectedDurations resources leak (GH-106795)
(cherry picked from commit 70b961e)

Co-authored-by: Yonatan Bitton <[email protected]>
@gpshead
Copy link
Member

gpshead commented Jul 19, 2023

thanks for figuring this out!

@picnixz picnixz removed the needs backport to 3.12 only security fixes label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@giampaolo giampaolo Awaiting requested review from giampaolo

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bityob @bedevere-bot @iritkatriel @sunmy2019 @giampaolo @miss-islington @gpshead @picnixz