gh-105481: expose opcode metadata via the _opcode module#106688
Merged
iritkatriel merged 10 commits intopython:mainfrom Jul 14, 2023
Merged
gh-105481: expose opcode metadata via the _opcode module#106688iritkatriel merged 10 commits intopython:mainfrom
iritkatriel merged 10 commits intopython:mainfrom
Conversation
Member
Author
|
There's a problem here with the definition of the metadata table. I'll try to sort it out tomorrow. |
gvanrossum
approved these changes
Jul 13, 2023
iritkatriel
commented
Jul 14, 2023
Misc/NEWS.d/next/Library/2023-07-13-16-04-15.gh-issue-105481.pYSwMj.rst
Outdated
Show resolved
Hide resolved
gvanrossum
approved these changes
Jul 14, 2023
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Something worries me about the amount of repetition for each flag. But the alternative (exposing the flags as an int, and the constants) seems worse. So go for it!
Member
Author
|
Yes, I didn't want to expose the bitmap implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.