gh-104924: Fix read()able in http.client log messages#104926
Merged
corona10 merged 2 commits intopython:mainfrom May 26, 2023
Merged
gh-104924: Fix read()able in http.client log messages#104926corona10 merged 2 commits intopython:mainfrom
read()able in http.client log messages#104926corona10 merged 2 commits intopython:mainfrom
Conversation
arhadthedev
added
docs
gaogaotiantian
requested changes
May 25, 2023
Member
gaogaotiantian
left a comment
gaogaotiantian
left a comment
There was a problem hiding this comment.
I think sendIng is an obvious typo. On line 1057, from some brief reading, it's not "sending" a readable, but "reading" from a readable(as indicated by the function name).
Co-authored-by: Tian Gao <[email protected]>
gaogaotiantian
approved these changes
May 25, 2023
|
I have looked for any related typo with “Ing the read()”. I know PyCharm can make funny replacements but I still haven’t found where this would come from. |
Contributor
|
Thanks @arhadthedev for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2023
…ongh-104926) (cherry picked from commit 6c81d75) Co-authored-by: Oleg Iarygin <[email protected]>
|
GH-104970 is a backport of this pull request to the 3.12 branch. |
|
GH-104971 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2023
…ongh-104926) (cherry picked from commit 6c81d75) Co-authored-by: Oleg Iarygin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/search?q=repo%3Apython%2Fcpython%20read()able&type=code shows no other occurrence of this typo.