gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending#103463
Merged
kumaraditya303 merged 7 commits intopython:mainfrom Apr 13, 2023
Merged
Conversation
Includes two failing tests that demonstrate a bug where if the data passed to writelines can't be sent in one shot, the remaining buffer isn't written since there is no registered write handler
If all the data in the buffer can't be written immediately schedule a writer to handle the remaining data.
alisaifee
requested review from
1st1,
asvetlov,
gvanrossum and
kumaraditya303
as code owners
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
alisaifee
changed the title
When the platform (windows) doesn't support it skip tests for writelines using sendmsg
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Contributor
kumaraditya303
left a comment
kumaraditya303
left a comment
There was a problem hiding this comment.
LGTM, Can you add a news entry? Thanks
Contributor
Author
done! |
Misc/NEWS.d/next/Library/2023-04-12-06-00-02.gh-issue-103462.w6yBlM.rst
Outdated
Show resolved
Hide resolved
kumaraditya303
approved these changes
Apr 13, 2023
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Apr 13, 2023
* main: pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495) pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494) pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502) pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500) pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507) pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228) pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463) pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
…a writer when data is still pending (python#103463)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the payload used with
SelectorSocketTransport.writelinesis too large to write in one call to eithersocket.sendorsocket.sendmsgthe remaining buffer needs to be handled by registering a write handler.Related Pull Request / Issue