gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer#103339
gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer#103339iritkatriel merged 8 commits intopython:mainfrom
Conversation
|
I see - the tests are skipped on Mac so I didn’t see them fail. I’ll try later on windows and fix this. |
There was a problem hiding this comment.
Order of PRs: (edited)
- Set sys.last_exc in run print_exception. #103314 (Done)
- Patch pyshell open_stack_viewer (comment on StackBrowser/stackbrowser)
- Apply this with changes and additional changes to open_stack_viewer and run-stackviewer and maybe new unittests.
Now working on 2 and 3.
The comments make a bit more sense when read in order on the diff page.
|
When you're done making the requested changes, leave the comment: |
|
I am reversing 2. patch open_stack_viewer and 3. everything else by including changing open_stack_viewer to pass sys.last_value, which is valid in 3.11 and 3.12. After merging this, I will patch main and 3.12 only to pass last_exc instead of last_value, thus removing, I believe, the last use of a deprecated value. |
|
Sorry, this seems to have dropped off my radar somehow. I'll update it now. |
|
Actually, are you working on this? (You seem to indicate so in #103339 (review)). |
|
I have a partly done branch. Will make this a priority tomorrow. |
|
Assuming CI passes, I believe ready now. Will recheck tomorrow. |
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…ackviewer (pythonGH-103339) (cherry picked from commit 3ee921d) Co-authored-by: Irit Katriel <[email protected]>
…ackviewer (pythonGH-103339) (cherry picked from commit 3ee921d) Co-authored-by: Irit Katriel <[email protected]>
|
GH-105526 is a backport of this pull request to the 3.12 branch. |
|
GH-105527 is a backport of this pull request to the 3.11 branch. |
Pass the exception as an argument instead of as a sys attribute.