gh-102837: few coverage nitpicks for the math module by skirpichev · Pull Request #102523 · python/cpython

skirpichev · 2023-03-08T07:04:22Z

input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168), ceil(L1165), floor(L1236,L1239) and dist(L2587,L2588,L2628).
drop inaccessible "if" branch (L3518) in perm_comb_small()
improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497), ditto fmod(L2378)
rewrite modf to fix inaccessible case(L2229), ditto for pow(L2988)

(all line numbers are wrt the main branch at 5e6661b)

Issue: Improve test coverage for the math module #102837

skirpichev · 2023-03-08T07:07:55Z

Note, c.f. #102067 for the cmath module - there are still some uncovered lines/branches.

skirpichev · 2023-03-08T14:18:52Z

@AlexWaygood, do you think this requires an issue?

AlexWaygood · 2023-03-08T14:21:30Z

@AlexWaygood, do you think this requires an issue?

Our policy is generally to require issues for all changes, unless they're extremely trivial (such as typo fixes).

(If the maintainers of the math module decide this doesn't need an issue then that's obviously fine, but I'm not a math module maintainer, so I don't want to decide that for them :)

skirpichev · 2023-03-08T15:32:22Z

On Wed, Mar 08, 2023 at 06:21:43AM -0800, Alex Waygood wrote: Our policy is generally to require issues for all changes, unless they're extremely trivial (such as typo fixes).

Ok. I thought this is trivial:)

- input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168) and dist(L2587,L2588,L2628). - rewrite math_floor like math_ceil (cover L1239) - drop inaccessible "if" branch (L3518) in perm_comb_small() - improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497), ditto fmod(L2378) - rewrite modf to fix inaccessible case(L2229), ditto for pow(L2988) (all line numbers wrt the main branch at 5e6661b)

Now exception messages kept in is_error(). This improve coverage for L1007.

hauntsaninja

Thanks!

Modules/mathmodule.c

skirpichev · 2023-09-02T09:14:07Z

Last commit will cover rest of math_floor()/ceil().

This reverts commit 9c32ae0.

hauntsaninja

Thanks for the follow ups! :-)

skirpichev · 2023-09-28T03:38:23Z

Next pr: #110000

Modules/mathmodule.c

Rewrite changes in python#102523

pythonGH-102523) (Only the test changes from pythonGH-102523 are cherry-picked) - input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168), ceil(L1165), floor(L1236,L1239) and dist(L2587,L2588,L2628). - improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497), ditto fmod(L2378) (all line numbers are wrt the main branch at 5e6661b)

bedevere-app · 2023-11-13T12:15:05Z

GH-112030 is a backport of this pull request to the 3.12 branch.

… (GH-112030) * gh-102837: improve test coverage for math module (GH-102523) (Only the test changes from GH-102523 are cherry-picked) - input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168), ceil(L1165), floor(L1236,L1239) and dist(L2587,L2588,L2628). - improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497), ditto fmod(L2378) (all line numbers are wrt the main branch at 5e6661b) * gh-102837: more tests for the math module (GH-111930) Add tests to improve coverage: * fsum: L1369, L1379, L1383, L1412 * trunc: L2081 * log: L2267 * dist: L2577, L2579 * hypot: L2632 * sumprod: L2744, L2754, L2774, L2778, L2781, L2785, L2831, L2835, L2838 * pow: L2982 * prod: L3294, L3308, L3318-3330 // line numbers wrt to 9dc4fb8 (cherry picked from commit c61de45) --------- Co-authored-by: Sergey B Kirpichev <[email protected]>

… (GH-112030) (GH-112041) [3.12] gh-102837: more tests for the math module (GH-111930)(GH-102523) (GH-112030) * gh-102837: improve test coverage for math module (GH-102523) (Only the test changes from GH-102523 are cherry-picked) - input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168), ceil(L1165), floor(L1236,L1239) and dist(L2587,L2588,L2628). - improve fsum coverage for exceptional cases (L1433,L1438,L1451,L1497), ditto fmod(L2378) (all line numbers are wrt the main branch at 5e6661b) * gh-102837: more tests for the math module (GH-111930) Add tests to improve coverage: * fsum: L1369, L1379, L1383, L1412 * trunc: L2081 * log: L2267 * dist: L2577, L2579 * hypot: L2632 * (not cherry-picked for 3.11: sumprod) * pow: L2982 * prod: L3294, L3308, L3318-3330 // line numbers wrt to 9dc4fb8 (cherry picked from commit c61de45) --------- Co-authored-by: Sergey B Kirpichev <[email protected]> (cherry picked from commit c6aea46)

bedevere-bot added the awaiting review label Mar 8, 2023

AlexWaygood added the skip news label Mar 8, 2023

mdickinson self-requested a review March 8, 2023 17:40

skirpichev force-pushed the math-cov branch from 3e3807b to 68b2e42 Compare March 20, 2023 07:26

skirpichev changed the title ~~Few coverage nitpicks for the math module~~ gh-102837: few coverage nitpicks for the math module Mar 20, 2023

bedevere-bot mentioned this pull request Mar 20, 2023

Improve test coverage for the math module #102837

Closed

skirpichev added 9 commits April 3, 2023 14:22

Merge branch 'main' into math-cov

dc85378

Merge branch 'main' into math-cov

86aee3c

Simplify math_1, like other functions

9c32ae0

Now exception messages kept in is_error(). This improve coverage for L1007.

Merge branch 'main' into math-cov

b8cf8ac

Merge branch 'main' into math-cov

b395cfb

Merge branch 'main' into math-cov

c3bd1cd

Merge branch 'main' into math-cov

dc8ac10

Merge branch 'main' into math-cov

acb851d

Merge branch 'main' into math-cov

a6c769e

hauntsaninja reviewed Sep 1, 2023

View reviewed changes

Modules/mathmodule.c Show resolved Hide resolved

Modules/mathmodule.c Outdated Show resolved Hide resolved

Modules/mathmodule.c Outdated Show resolved Hide resolved

skirpichev added 3 commits September 2, 2023 05:14

Merge branch 'math-cov' of github.com:skirpichev/cpython into math-cov

d45ea20

Merge branch 'main' into math-cov

59a5422

Add asserts

a0c619b

skirpichev requested a review from hauntsaninja September 2, 2023 02:36

skirpichev force-pushed the math-cov branch from 6634b88 to a0c619b Compare September 2, 2023 03:24

Amend 9c32ae0 (comment restored)

b991b7c

hauntsaninja reviewed Sep 2, 2023

View reviewed changes

Modules/mathmodule.c Outdated Show resolved Hide resolved

Modules/mathmodule.c Outdated Show resolved Hide resolved

skirpichev added 2 commits September 2, 2023 09:15

Merge branch 'main' into math-cov

192a279

Revert back math_floor(), add tests to cover L1239 (same for ceil())

828ba75

Tests for bad __floor__/__ceil__ descriptors (cover L1165, L1236)

6498162

skirpichev added 3 commits September 3, 2023 06:42

+1

8fcca16

Revert "Simplify math_1, like other functions"

796bdca

This reverts commit 9c32ae0.

Merge branch 'main' into math-cov

c7d1764

skirpichev requested a review from hauntsaninja September 3, 2023 04:29

hauntsaninja approved these changes Sep 3, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Sep 3, 2023

hauntsaninja merged commit 9c995ab into python:main Sep 3, 2023

bedevere-bot removed the awaiting merge label Sep 3, 2023

skirpichev deleted the math-cov branch September 3, 2023 09:03

skirpichev mentioned this pull request Sep 3, 2023

gh-110489: Optimise math.ceil for known exact float #108801

Merged

This was referenced Sep 26, 2023

gh-101410: Improve error messages in math module #101492

Closed

gh-102837: Increase test coverage for the math module #110000

Closed

serhiy-storchaka reviewed Oct 6, 2023

View reviewed changes

Modules/mathmodule.c Show resolved Hide resolved

Modules/mathmodule.c Show resolved Hide resolved

skirpichev added a commit to skirpichev/cpython that referenced this pull request Oct 6, 2023

More efficient (for finite x) handling of special cases in math.modf

3df127e

Rewrite changes in python#102523

skirpichev mentioned this pull request Nov 13, 2023

[3.12] gh-102837: more tests for the math module (GH-111930) #112029

Closed

encukou mentioned this pull request Nov 13, 2023

[3.11] gh-102837: more tests for the math module (GH-111930)(GH-102523) (GH-112030) #112041

Merged

Uh oh!

Conversation

skirpichev commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skirpichev commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skirpichev commented Mar 8, 2023

Uh oh!

AlexWaygood commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skirpichev commented Mar 8, 2023 via email

Uh oh!

hauntsaninja left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skirpichev commented Sep 2, 2023

Uh oh!

hauntsaninja left a comment

Choose a reason for hiding this comment

Uh oh!

skirpichev commented Sep 28, 2023

Uh oh!

Uh oh!

Uh oh!

bedevere-app bot commented Nov 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

skirpichev commented Mar 8, 2023 •

edited

Loading

skirpichev commented Mar 8, 2023 •

edited

Loading

AlexWaygood commented Mar 8, 2023 •

edited

Loading