gh-101384: add socket timeout to ThreadedVSOCKSocketStreamTest and skip it on WSL#101418
Closed
peterjpxie wants to merge 3 commits intopython:mainfrom
Closed
gh-101384: add socket timeout to ThreadedVSOCKSocketStreamTest and skip it on WSL#101418peterjpxie wants to merge 3 commits intopython:mainfrom
peterjpxie wants to merge 3 commits intopython:mainfrom
Conversation
added 2 commits
January 30, 2023 19:45
…st failure. 2/ Skip ThreadedVSOCKSocketStreamTest on WSL.
Contributor
Author
|
Forgot to set user.email and user.name and it ends up with a invalid author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1/ Add socket server timeout to ThreadedVSOCKSocketStreamTest so that it does not hang on client connection failure, e.g. on WSL.
After adding the timeout, it was able to fail on this test and continue as follows.
2/ Furthermore, as it does not work on WSL (OSError: [Errno 101] Network is unreachable), skip it on WSL.
This works on VMware workstation for communication between VM guests and host.