IDLE: Simplify DynOptionsMenu __init__code#101371
Merged
terryjreedy merged 4 commits intopython:mainfrom Feb 28, 2023
Merged
Conversation
|
All commit authors signed the Contributor License Agreement. |
terryjreedy
reviewed
Jan 27, 2023
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
#71942 proposes to eliminate this file, but I plan to apply this now with the change in the comment and replacement of the htest line with
dyn = DynOptionMenu(top,var, "old1","old2","old3", highlightthickness=0)
The efficiency gain I care about is in reading the code ;-)
terryjreedy
added
awaiting changes
skip issue
skip news
needs backport to 3.10
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Contributor
Author
|
Hi @terryjreedy, I've applied the patch you suggested. |
terryjreedy
changed the title
terryjreedy
approved these changes
Feb 28, 2023
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I improved init docstring and added highlightthickness to htest and note as to why no unittests.
Contributor
|
Thanks @JosephSBoyle for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-102314 is a backport of this pull request to the 3.11 branch. |
|
GH-102315 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 28, 2023
Refactor DynOptionMenu's initializer to not copy kwargs dict and use subscripting; improve its htest. (cherry picked from commit c41af81) Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 28, 2023
Refactor DynOptionMenu's initializer to not copy kwargs dict and use subscripting; improve its htest. (cherry picked from commit c41af81) Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Feb 28, 2023
Refactor DynOptionMenu's initializer to not copy kwargs dict and use subscripting; improve its htest. (cherry picked from commit c41af81) Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Feb 28, 2023
Refactor DynOptionMenu's initializer to not copy kwargs dict and use subscripting; improve its htest. (cherry picked from commit c41af81) Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Member
|
Backports merged. |
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Feb 28, 2023
* main: (67 commits) pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308) pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333) pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331) pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309) Migrate to new PSF mailgun account (python#102284) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193) pythonGH-90744: Fix erroneous doc links in the sys module (python#101319) pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093) pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102) IDLE: Simplify DynOptionsMenu __init__code (python#101371) pythongh-101561: Add typing.override decorator (python#101564) pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843) pythongh-101773: Optimize creation of Fractions in private methods (python#101780) pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254) pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297) pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287) pythongh-101100: Fix sphinx warnings in `types` module (python#102274) pythongh-91038: Change default argument value to `False` instead of `0` (python#31621) pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283) [doc] Improve grammar/fix missing word (pythonGH-102060) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dynoption.py, don't copy the kwargs dict and do use subscript syntax for config.
Testing
To test the changes don't break anything, simply set the 'highlightthickness' value:
and run the script: