gh-98831: add variable stack effect support to cases generator#101309
Merged
iritkatriel merged 4 commits intopython:mainfrom Jan 25, 2023
Merged
gh-98831: add variable stack effect support to cases generator#101309iritkatriel merged 4 commits intopython:mainfrom
iritkatriel merged 4 commits intopython:mainfrom
Conversation
Member
Author
|
We’ll want something more efficient than this. Maybe generate a function with a switch statement for each value? |
gvanrossum
reviewed
Jan 25, 2023
Member
Yes. Read this after writing my response. :-) |
gvanrossum
reviewed
Jan 25, 2023
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Very nice, just one request and one suggestion.
| self.out.emit(f" case {instr.name}:") | ||
| self.out.emit(f" return {effect};") | ||
| self.out.emit(" default:") | ||
| self.out.emit(" Py_UNREACHABLE();") |
Member
There was a problem hiding this comment.
If you make this return -1; then you can drop all the cases that return -1, making the function much shorter.
Member
Author
There was a problem hiding this comment.
There won't be any -1's when we finish. We could group all cases with the same value if we want.
gvanrossum
approved these changes
Jan 25, 2023
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Jan 25, 2023
mdboom
pushed a commit
to mdboom/cpython
that referenced
this pull request
Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.