gh-89381: Fix invalid signatures of math/cmath.log#101070
Closed
skirpichev wants to merge 1 commit intopython:mainfrom
skirpichev:fix-89381
Closed
gh-89381: Fix invalid signatures of math/cmath.log#101070skirpichev wants to merge 1 commit intopython:mainfrom skirpichev:fix-89381
skirpichev wants to merge 1 commit intopython:mainfrom
skirpichev:fix-89381
Conversation
Contributor
|
Thanks for the PR! I was curious about why the existing code in mathmodule.c didn't work. It turns out that it is I think easy to fix, which led me to make an alternate PR here: #101115. I think that PR is a slightly smaller change / closer to what whoever did the original argument clinic for mathmodule.c intended. But maybe c_default is sketchy or support for None is desirable, in which case this PR works too! |
Member
Author
|
@hauntsaninja, thanks. I left few notes on the new PR. |
Member
Author
|
Closed per #101123 |
mdickinson
reviewed
Jan 29, 2023
| Returns the logarithm of *x* to the given *base*. If the *base* is not | ||
| specified, returns the natural logarithm of *x*. There is one branch cut, from 0 | ||
| along the negative real axis to -∞, continuous from above. | ||
| specified or is None, returns the natural logarithm of *x*. There is one |
Member
There was a problem hiding this comment.
In the interests of readability, I'd suggest reverting the change on this line - I think it's clear from context that "not specified" includes the case of deliberately specifying None.
Member
Author
|
reopened as #101404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.