gh-94518: Rename group* to extra_group* to avoid confusion#101054
Merged
gpshead merged 7 commits intopython:mainfrom Jan 26, 2023
Merged
gh-94518: Rename group* to extra_group* to avoid confusion#101054gpshead merged 7 commits intopython:mainfrom
group* to extra_group* to avoid confusion#101054gpshead merged 7 commits intopython:mainfrom
Conversation
Member
Author
|
Converted to draft because |
Member
Author
|
Converted to draft again to rerun tests because spurious |
Member
Author
|
Removed spuriously added technical However, a new |
gpshead
approved these changes
Jan 26, 2023
mdboom
pushed a commit
to mdboom/cpython
that referenced
this pull request
Jan 31, 2023
…ython#101054) * Rename `group*` to `extra_group*` to avoid confusion * Rename `num_groups` into `extra_group_size` * Rename `groups_list` to `extra_groups_packed`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #94687 (comment):
Edit: this PR also unifies terminology by further renaming
groups_listparameter andnum_groupsvariable intoextra_groups_packedandextra_group_size.cc @gpshead
_posixsubprocess.fork_execto Argument Clinic #94518