Conversation
|
The tests on urls.py seems to fail. I'm not sure if changes on domain.py affect the latter. Also, the domain validator depends on the internet to fetch the list of TLDs, Do we need to have a static list in case the data can't be pulled? |
Yes, URLs are composed of either ip-address or domain.
I'd prefer caching TLDs. For now, I'll put this PR on hold, because:
Feel free to work on |
|
Ok cool, let me look what I can do on |
|
c5f8f78 to
73d540f
Compare
|
Just want to bring the attention to this library that already handle this, maybe we can use it or take inspiration: |
The TLD in the domain validator are checked against a valid list of TLDs from "https://data.iana.org/TLD/tlds-alpha-by-domain.txt"
This pull request solves #198