Skip to content

maint: misc fixes and improvements#249

Merged
nandgator merged 1 commit intopython-validators:masterfrom
nandgator:workshop
Mar 20, 2023
Merged

maint: misc fixes and improvements#249
nandgator merged 1 commit intopython-validators:masterfrom
nandgator:workshop

Conversation

@nandgator
Copy link
Copy Markdown
Collaborator

  • sorts import using isort
  • return False on empty value
  • fix invalid parameter name in url docstring
  • use tuple when iterating over sequence
  • # project is replaced by # local
  • pyaml is an external library which provides yaml
  • pre-commit-config now has black, isort and flake8
  • tox can now run tests, formatting, linting and type-checking
  • i18n exclusion is only temporary
  • re-order some configurations in pyproject.toml

This PR will be closed in an hour.

- sorts import using `isort`
- return `False` on empty `value`
- fix invalid parameter name in `url` docstring
- use tuple when iterating over sequence
- `# project` is replaced by `# local`
- `pyaml` is an external library which provides `yaml`
- pre-commit-config now has `black`, `isort` and `flake8`
- tox can now run tests, formatting, linting and type-checking
- `i18n` exclusion is only temporary
- re-order some configurations in `pyproject.toml`
@nandgator nandgator added review PR: Can be reviewed development Issue/PR: Modification in workflows, packaging, etc. maintenance PR: Alters existing source code labels Mar 20, 2023
@nandgator nandgator self-assigned this Mar 20, 2023
@nandgator nandgator merged commit 24675a3 into python-validators:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Issue/PR: Modification in workflows, packaging, etc. maintenance PR: Alters existing source code review PR: Can be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant