Skip to content

maint: improve domain, email & hostname#244

Merged
nandgator merged 1 commit intopython-validators:masterfrom
nandgator:workshop
Mar 17, 2023
Merged

maint: improve domain, email & hostname#244
nandgator merged 1 commit intopython-validators:masterfrom
nandgator:workshop

Conversation

@nandgator
Copy link
Copy Markdown
Collaborator

@nandgator nandgator commented Mar 17, 2023

  • in domain: decode value to utf-8 instead of ascii; use re.match directly
  • in email: split ip_address to ipv4 and ipv6 parameters
  • in hostname: split skip_ip_addr to skip ipv4 & ipv6 parameters

This PR will be closed in an hour.

@nandgator nandgator added review PR: Can be reviewed maintenance PR: Alters existing source code labels Mar 17, 2023
@nandgator nandgator self-assigned this Mar 17, 2023
@nandgator
Copy link
Copy Markdown
Collaborator Author

nandgator commented Mar 17, 2023 •
edited
Loading

Not sure why the diff on GitHub looks weird. Locally it's fine:

image

It was line ending :/

@nandgator
maint: improve domain, email & hostname
060c96d 
- in `domain`: decode value to `utf-8` instead of `ascii`; use `re.match` directly
- in `email`: split `ip_address` to `ipv4` and `ipv6` parameters
- in `hostname`: split `skip_ip_addr` to skip `ipv4` & `ipv6` parameters
@nandgator nandgator removed the review PR: Can be reviewed label Mar 17, 2023
@nandgator nandgator merged commit bbf4600 into python-validators:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nandgator nandgator

Labels

maintenance PR: Alters existing source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nandgator