-
Notifications
You must be signed in to change notification settings - Fork 174
Private ip addresses being validated with public=True #206
Copy link
Copy link
Closed
Labels
bugIssue: Works not as designedIssue: Works not as designedoutdatedIssue/PR: Open for more than 3 monthsIssue/PR: Open for more than 3 months
Description
There is no guarantee that setting this flag to True will get a "public IP address". A domain might point to private IP addresses, (like vcap.me which points to 127.0.0.1), so trusting public=True could lead to security issues
>>> url("https://127.0.0.1", public=True)
False
>>> url("http://vcap.me", public=True)
True
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue: Works not as designedIssue: Works not as designedoutdatedIssue/PR: Open for more than 3 monthsIssue/PR: Open for more than 3 months