Skip to content

simplify marker simplification - #7136

Merged
radoering merged 1 commit into
python-poetry:masterfrom
dimbleby:simplify-marker-simplification
Dec 11, 2022
Merged

radoering merged 1 commit into
python-poetry:masterfrom
dimbleby:simplify-marker-simplification

Conversation

@dimbleby

@dimbleby dimbleby commented Dec 3, 2022 •

Copy link
Copy Markdown
Contributor

The simplification and generalization of marker parsing and merging in python-poetry/poetry-core#530 results in markers being parsed to disjunctive normal form.

Obviously needs coordination with python-poetry/poetry-core#530

@radoering

Copy link
Copy Markdown
Member

Can we just make the test forward compatible like assert marker in [variant1, variant2] to keep coordination simple? I think we can even keep this after the next core release so we don't have to adapt the test again if the marker changes to the original variant for some reason in the future.

@dimbleby
dimbleby force-pushed the simplify-marker-simplification branch from 4774b08 to c2c9347 Compare December 10, 2022 14:14
@radoering
radoering force-pushed the simplify-marker-simplification branch from c2c9347 to 6f3f712 Compare December 11, 2022 11:47
@radoering radoering added impact/backport Requires backport to stable branch backport/1.3 labels Dec 11, 2022
@radoering
radoering enabled auto-merge (squash) December 11, 2022 11:50
@radoering
radoering merged commit 0c8e5b4 into python-poetry:master Dec 11, 2022
poetry-bot Bot pushed a commit that referenced this pull request Dec 11, 2022
@dimbleby
dimbleby deleted the simplify-marker-simplification branch December 11, 2022 11:54
radoering pushed a commit that referenced this pull request Dec 11, 2022
@neersighted neersighted added this to the 1.4 milestone Jan 15, 2023
@neersighted neersighted added area/solver Related to the dependency resolver kind/refactor Pulls that refactor, or clean-up code labels Jan 15, 2023
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/solver Related to the dependency resolver impact/backport Requires backport to stable branch kind/refactor Pulls that refactor, or clean-up code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants