Merged
Conversation
Member
|
@moonsikpark this would be easier to merge if you can squash the commits into two please?
|
moonsikpark
force-pushed
the
fix/7006-remove-nulllocker
branch
3 times, most recently
from
87fca65 to
8604b26
Compare
Contributor
Author
|
@abn No problem. |
moonsikpark
force-pushed
the
fix/7006-remove-nulllocker
branch
from
8604b26 to
8c67743
Compare
Secrus
approved these changes
Nov 16, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #7006
mypyintroduced python/mypy#12118, and it fails withempty-bodyon functions with empty body like thisNullLockerimplementation.poetry/src/poetry/packages/locker.py
Lines 469 to 471 in b28339d
It seems there is no downstream usage of this class on GitHub that we are aware of that will break implicitly. This PR deletes
NullLockerand bump the version ofmypyto 0.990, which is the latest.