Skip to content

Standardise on using virtualenv package - #2666

Merged
sdispater merged 1 commit into
python-poetry:developfrom
abn:virtualenv
Jul 14, 2020
Merged

sdispater merged 1 commit into
python-poetry:developfrom
abn:virtualenv

Conversation

@abn

@abn abn commented Jul 13, 2020 •

Copy link
Copy Markdown
Member

Until now poetry used the built-in venv module available in Python 3.
This has presented a few concerns. Chief of which has been
inconsistent environment setup. This includes, but is not limited to,
pip version used by the ensurepip module which is in turn used by the
built-in venv.EnvBuilder. Additionally, the virtualenv package
allows for faster environment creation. This can also allow us to, going
forward, drop ad-hoc code required to inspect and manage environments.

See also: #2650
Closes: #732

  • Added tests for changed code.]

@abn
abn requested a review from sdispater July 13, 2020 21:44
Until now poetry used the built-in venv module available in Python 3.
This has presented a few concerns. Chief of which has been
inconsistent environment setup. This includes, but is not limited to,
pip version used by the `ensurepip` module which is in turn used by the
built-in `venv.EnvBuilder`. Additionally, the `virtualenv` package
allows for faster environment creation. This can also allow us to, going
forward, drop ad-hoc code required to inspect and manage environments.

@sdispater sdispater left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@sdispater
sdispater merged commit d5a99f0 into python-poetry:develop Jul 14, 2020
@sdispater sdispater mentioned this pull request Jul 24, 2020
@abn
abn deleted the virtualenv branch September 23, 2020 14:20
@senpos senpos mentioned this pull request Oct 7, 2020
2 tasks done
@abn abn linked an issue Nov 2, 2020 that may be closed by this pull request
3 tasks done
@abn abn mentioned this pull request Mar 29, 2021
2 tasks done
@github-actions

github-actions Bot commented Mar 1, 2024

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

2 participants