Skip to content

Removal of master branch in poetry-core on June 1, 2023 #6741

Closed

Description

@mkniewallner

The main branch of poetry-core was renamed from master to main in May 2022. Since this broke some packages explicitly referencing master, it was decided to copy the main branch into master branch to not break those usages.

As master is not updated from main, and it is confusing to keep both branches around, there's no point keeping master indefinitely.

So this issue acts as a deprecation notice for usages of master branch of poetry-core, as we are planning to delete the branch on June 1, 2023.

This change will impact packages that use git references when defining poetry-core as a build-system, for instance by doing:

[build-system]
requires = ["poetry-core @ git+https://github.com/python-poetry/poetry-core.git@master"]
build-backend = "poetry.core.masonry.api"

Once master branch is removed, any package still referencing master branch as their build system will not be installable. Note that using a moving git branch for the build system on published packages is a highly discouraged practice, since:

  • update to branches could break usages at any moment, as they represent a development version of the project, and not official releases
  • branches are not immutable, and can be deleted in git

If you are a package maintainer and are referencing poetry-core by using master branch from the git repository (or any other branch, for what it's worth), it is highly recommended to update the build system of the package to rely on versions published to PyPI, for instance:

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

or, if you rely on features implemented in specific versions of poetry-core, by defining a lower bound, for instance:

[build-system]
requires = ["poetry-core>=1.2.0"]
build-backend = "poetry.core.masonry.api"

Activity

  1. added
    area/build-systemRelated to PEP 517 packaging (see poetry-core)
    area/coreRelated to the poetry-core library
    impact/deprecationIntroduces or relates to a deprecation
    on Oct 7, 2022
  2. pinned this issue on Apr 27, 2023
  3. Secrus commented on Jun 5, 2023

    @Secrus
    Member

    The master branch in poetry-core was dropped.

  4. unpinned this issue on Jun 5, 2023
  5. added a commit that references this issue on Jun 9, 2023
  6. added a commit that references this issue on Jul 7, 2023
  7. github-actions commented on Feb 29, 2024

    @github-actions

    This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  8. locked as resolved and limited conversation to collaborators on Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/coreRelated to the poetry-core libraryimpact/deprecationIntroduces or relates to a deprecation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions