Repository navigation
extras_require ignores version specifier #3163
Description
- I am on the latest Poetry version.
- I have searched the issues of this repo and believe that this is not a duplicate.
- If an exception occurs when executing a command, I executed it again in debug mode (
-vvvoption).
- OS version and name: MacOS 10.15
- Poetry version: 1.1.2
- pyproject.toml / setup.py: https://gist.github.com/Fizzadar/a1b98304a2b86ee966dedea6479320bd
Issue
The extras_require in the generated setup.py ignores the version specified in the pyproject.toml, leading to inconsistent/broken builds when installing a package with extras.
Gist above contains full info, but specifically:
[tool.poetry.dependencies]
kombu = {version = '^=4.5', optional = true}
[tool.poetry.extras]
queue = ['kombu']Becomes:
extras_require = \
{'queue': ['kombu']}
Activity
abn commentedon Oct 9, 2020
@Fizzadar you can add the following to your
pyproject.tomlto avoid this altogether. Poetry will stop generating setup files by default in coming release.abn commentedon Oct 9, 2020
The issue lies in thow the SdistBuilder computes extras from the
pyproject.toml. The fix needs to happen inpoetry-core. We must, retrive extra dependencies from project level dependencies prior to serialising them.iadi7ya commentedon Oct 10, 2020
Hi @abn Can I take this up?
abn commentedon Oct 10, 2020
@iadi7ya definitely. If you need input, feel free to ping on discord.
Please read #3061 before contributing.
abn commentedon Oct 13, 2020
@iadi7ya is this something you are still working on?
iadi7ya commentedon Oct 14, 2020
I am not able to figure out solution for this.
abn commentedon Oct 14, 2020
As mentioned in #3061, feel free to discuss this on discord. Happy to give you pointers if you want to contirbute. The crux of what needs to be done is highlighted in the my comment above.
dimbleby commentedon Sep 2, 2022
This issue is a big misunderstanding, the actual problem is this bogus version
^=4.5if you replace that with
^4.5which is presumably what was intended then the requirement comes out as'kombu>=4.5,<5.0'.so it would still be nice if poetry rejected the bad version rather than somehow interpreting it as being
*: but that's the real problem.github-actions commentedon Mar 1, 2024
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.