Skip to content

Source Trove classifiers from canonical PyPA definitions #2579

Closed

Description

@kdeldycke
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

I just stumble upon https://github.com/pypa/trove-classifiers , a package published and maintained by PyPA that is cataloguing all current and deprecated classifiers recognized on pypi.org . This is the canonical source of all trove definitions.

I propose to rely on this package to validate and check classifiers produced by poetry. Is that a good idea?

Activity

  1. kdeldycke commented on Jun 18, 2020

    @kdeldycke
    ContributorAuthor

    Oh. One more thing: with the advance of a plugin system in the upcoming Poetry 1.1 release (see: #1856), shouldn't we send there a PR to add a new classifier dedicated to Poetry? Something like: Framework :: Poetry.

  2. pradyunsg commented on Jun 18, 2020

    @pradyunsg
    Contributor

    For a new classifier, a request needs to be made to PyPI admins, and one of the criterion is that the classifier is immediately useful to at least 10 other packages/package maintainers (to avoid the case of adding classifiers for folks' pet projects that no one else uses).

    I think it'd be worthwhile to wait until after the 1.1 release, before requesting for addition of the trove classifier.

  3. kdeldycke commented on Jun 18, 2020

    @kdeldycke
    ContributorAuthor

    @pradyunsg oh yes you're right. In the mean time I checked the criterions for new inclusion and indeed, the classifier needs an existing base of relative popularity before being admitted into the reference. And I totally get it to not pollute the catalogue with short-lived or unmaintained projects.

  4. abn commented on Jun 19, 2020

    @abn
    Member

    @kdeldycke I think it is reasonable to add this into the check command. I'd be hesitent to enforce this elsewhere however.

  5. kdeldycke commented on Sep 2, 2020

    @kdeldycke
    ContributorAuthor

    Thanks @abn for the suggestion! I just pushed a PR at #2881 that is doing exactly that.

  6. added a commit that references this issue on Sep 18, 2022
    ddf36aa
  7. github-actions commented on Mar 1, 2024

    @github-actions

    This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  8. locked as resolved and limited conversation to collaborators on Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureFeature requests/implementations

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions