Skip to content

test(dependency): increase test coverage for VCSDependency.to_pep_508() #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radoering merged 1 commit into from
Aug 27, 2022
Merged

test(dependency): increase test coverage for VCSDependency.to_pep_508() #453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 39 additions & 17 deletions tests/packages/test_vcs_dependency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,52 @@
from __future__ import annotations

from typing import Any

import pytest

from poetry.core.packages.vcs_dependency import VCSDependency


def test_to_pep_508() -> None:
@pytest.mark.parametrize(
"kwargs, expected",
[
({}, "poetry @ git+https://github.com/python-poetry/poetry.git"),
(
{"extras": ["foo"]},
"poetry[foo] @ git+https://github.com/python-poetry/poetry.git",
),
(
{"extras": ["foo", "bar"]},
"poetry[bar,foo] @ git+https://github.com/python-poetry/poetry.git",
),
(
{"branch": "main"},
"poetry @ git+https://github.com/python-poetry/poetry.git@main",
),
(
{"tag": "1.0"},
"poetry @ git+https://github.com/python-poetry/poetry.git@1.0",
),
(
{"rev": "12345"},
"poetry @ git+https://github.com/python-poetry/poetry.git@12345",
),
(
{"directory": "sub"},
"poetry @ git+https://github.com/python-poetry/poetry.git#subdirectory=sub",
),
(
{"branch": "main", "directory": "sub"},
"poetry @ git+https://github.com/python-poetry/poetry.git"
"@main#subdirectory=sub",
),
],
)
def test_to_pep_508(kwargs: dict[str, Any], expected: str) -> None:
dependency = VCSDependency(
"poetry", "git", "https://github.com/python-poetry/poetry.git"
"poetry", "git", "https://github.com/python-poetry/poetry.git", **kwargs
)

expected = "poetry @ git+https://github.com/python-poetry/poetry.git"

assert dependency.to_pep_508() == expected


Expand All @@ -23,19 +58,6 @@ def test_to_pep_508_ssh() -> None:
assert dependency.to_pep_508() == expected


def test_to_pep_508_with_extras() -> None:
dependency = VCSDependency(
"poetry",
"git",
"https://github.com/python-poetry/poetry.git",
extras=["foo", "bar"],
)

expected = "poetry[bar,foo] @ git+https://github.com/python-poetry/poetry.git"

assert dependency.to_pep_508() == expected


def test_to_pep_508_in_extras() -> None:
dependency = VCSDependency(
"poetry", "git", "https://github.com/python-poetry/poetry.git"
Expand Down