Repository navigation
Cleo exceptions don't use pep8 naming conventions (and pep8-naming flake8 plugin doesn't seem to care) #162
Description
Cleo's exceptions end in the suffix *Exception. PEP8 stipulates that exceptions should end in the suffix *Error. The pep8-naming flake8 extension is installed as a pre-commit hook, but is not triggering (for some reason).
Activity
Secrus commentedon Jul 4, 2022
I investigated this a bit.
pep8-namingis adding this error to default ignore of flake8 config here. I think it's to be adjusted in flake8 config.Secrus commentedon Jul 12, 2022
I tried activating the
flake8error, but with no luck. Might be just my lack of experience with configuringflake8. However, I don't think that*Exceptionis really wrong. I know it's not strictly in line with PEP8, but it's quite common to see it in projects.