setup.py: Use pkgconfig.parse()#204
Merged
Merged
Conversation
This commit doesn't change the behavior at all, but sets things up to make it easier to integrate with pkgconfig.parse() in a future commit.
Rather than using pkgconfig.libs() and pkgconfig.cflags() directly, use pkgconfig.parse(), which returns a dictionary suitable for passing as keyword arguments to the Extension constructor.
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 86.55% 86.55%
=======================================
Files 4 4
Lines 238 238
=======================================
Hits 206 206
Misses 32 32 Continue to review full report at Codecov.
|
Member
|
Thank you very much for this, your time and effort is very much appreciated! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #203 (comment) to use
pkgconfig.parse()instead of callingpkgconfig.cflags()andpkgconfig.libs()directly. The first commit is just some refactoring to make this easier, and the second commit switches thepkgconfigmethod that's used.