Run ruff format when lsp formatting is invoked#56
Closed
mmcshane wants to merge 1 commit intopython-lsp:mainfrom
Closed
Run ruff format when lsp formatting is invoked#56mmcshane wants to merge 1 commit intopython-lsp:mainfrom
ruff format when lsp formatting is invoked#56mmcshane wants to merge 1 commit intopython-lsp:mainfrom
Conversation
Adds the Subcommand enum to indicate which `ruff` subcommand should be executed by `run_ruff`. At this time, only `check` and `format` are supported. As different subcommands support different parameters, argument generation is delegated based on the specific subcommand value. The `ruff format` subcommand does not currently organize imports and there does not appear to be a way to convince it to do so. Until a unified command exists the approach taken here is to format and then make a second run of `ruff check` that _only_ performs import formatting.
Contributor
Author
|
Whoops. I'll come back with something that works 3.7+ |
Member
|
We dropped support for Python 3.7 in python-lsp-server in version 1.8.0, so I think there's no need for it still being supported here. |
Contributor
Author
|
Oh well I was using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Subcommand enum to indicate which
ruffsubcommand should be executed byrun_ruff. At this time, onlycheckandformatare supported. As different subcommands support different parameters, argument generation is delegated based on the specific subcommand value.The
ruff formatsubcommand does not currently organize imports and there does not appear to be a way to convince it to do so. Until a unified command exists the approach taken here is to format and then make a second run ofruff checkthat only performs import formatting.Pursuant to #53