Fixed bug where preparse() wasn't called before parsing#420
Fixed bug where preparse() wasn't called before parsing#420tleonhardt merged 3 commits intomasterfrom
Conversation
Also: - Deleted postparse() since it was redundant with postparsing_precmd()
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 88.94% 88.97% +0.02%
==========================================
Files 9 9
Lines 2678 2676 -2
==========================================
- Hits 2382 2381 -1
+ Misses 296 295 -1
Continue to review full report at Codecov.
|
|
As long as everyone is happy with how I handled this issue, then this is the last thing I wanted to get in before we do a 0.9.0 release. I think we are ready for an 0.8.6 release as-is from the python2 branch. |
kotfu
left a comment
There was a problem hiding this comment.
I'd defer the preparse() and postparse() changes until a later release. As currently implemented the preparse() call will not receive all of the arguments of a multiline command.
|
@kotfu Are you happy with the |
|
Yup. |
Deleted
postparse()since it was redundant withpostparsing_precmd()- Decided to keep
postparsing_precmd()because of its more self-documenting namepostparse()in the docsThis partially addresses #417