Unit test coverage for transcripts from history#387
Merged
tleonhardt merged 7 commits intomasterfrom May 5, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 88.98% 89.58% +0.59%
==========================================
Files 8 8
Lines 2615 2630 +15
==========================================
+ Hits 2327 2356 +29
+ Misses 288 274 -14
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
May 5, 2018
| else: | ||
| self.poutput(hi.pr()) | ||
|
|
||
| def _generate_transcript(self, history, transcript_file): |
Member
There was a problem hiding this comment.
Thanks for refactoring and improving this.
| ('dotstar.txt', False), | ||
| ('extension_notation.txt', False), | ||
| # ('from_cmdloop.txt', True), | ||
| ('from_cmdloop.txt', True), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.