Move SMTP driver code into a function - #67
Merged
Conversation
pytest_localserver.smtp allows running itself as a module to start up an SMTP server, which is implemented by a bit of driver code guarded by an `if __name__ == "__main__"` block. Typical best practice is to put that code in a `main()` function, which is what I'm doing in this commit.
Python 2.4 is no longer anywhere close to supported so we can put `except` and `finally` in the same `try` block now.
coordt
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest_localserver.smtpallows running itself as a module to start up an SMTP server, which is implemented by a bit of driver code guarded by anif __name__ == "__main__"block. Typical best practice is to put that code in amain()function, which is what I'm doing in this commit.