Make pypi deployment dependent on test-pypi deployment - #64
Merged
Conversation
This commit changes the deployment to PyPI to be dependent on successful deployment to Test PyPI. Without this we would have to manually check that the deployment to Test PyPI succeeded before deploying to PyPI, and there's really no point in making that a manual process. (Or, a person could just deploy to PyPI directly without even waiting for the Test PyPI deployment to succeed and in that case there's no point in even deploying to Test PyPI first.) I was inspired to do this by looking at the release workflow for some other project, but I forget which one it was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the deployment to PyPI to be dependent on successful deployment to Test PyPI. Without this we would have to manually check that the deployment to Test PyPI succeeded before deploying to PyPI, and there's really no point in making that a manual process. (Or, a person could just deploy to PyPI directly without even waiting for the Test PyPI deployment to succeed and in that case there's no point in even deploying to Test PyPI first.)
I was inspired to do this by looking at the release workflow for some other project, but I forget which one it was.