Release using GitHub actions - #58
Merged
Merged
Conversation
coordt
approved these changes
Jan 22, 2023
This commit updates the pre-commit configuration to use a newer version of the GitHub actions linter, which gives better error messages for workflows involving environments.
In this commit I'm adding a new workflow which will build distributable packages for pytest-localserver and upload them to PyPI and Test PyPI. The uploads are treated as deployments, so they will not run until someone manually approves them. A future enhancement I'd like to make is to actually run tests using the same package that is going to be uploaded. That's going to involve tweaking tox to install from a prebuilt package rather than directly from the source code, so it will take some time to figure that out.
diazona
force-pushed
the
release-using-github-actions/1/dev
branch
from
January 23, 2023 03:31
0ee01bc to
83f3542
Compare
diazona
marked this pull request as ready for review
January 23, 2023 04:23
Contributor
Author
|
@coordt Would you mind rechecking this? I went through several different iterations of this while testing, some of which included changes not intended for merging into master (like deleting the entire test workflow for a little while 😆), and I'd like to get a second pair of eyes to confirm that I didn't leave in a bad change. |
Now that we have an automatic flow for making releases and uploading to PyPI (and Test PyPI), I'm updating the instructions in the README file to reflect it instead of the manual release flow that we used to use.
diazona
force-pushed
the
release-using-github-actions/1/dev
branch
from
January 23, 2023 20:50
2d4bbe0 to
3212bc2
Compare
Contributor
Author
|
Hopefully I can trust myself 3 days later to ensure nothing untoward snuck in here 😄 I'll merge now to prepare for a final release tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a workflow for pushing to PyPI.