Use older Ubuntu for testing with Python 3.5 and 3.6 - #56
Merged
Conversation
This commit changes the Github Actions workflow configuration to use an older version of Ubuntu for testing on Python 3.5 and 3.6 - namely Ubuntu 20.04 instead of the current default 22.04. The runners that Github provides with Ubuntu 22.04 don't support versions of Python prior to 3.7. We will remove support for Python <3.7 at some point, when a code change makes it necessary, but for now there happens to be nothing in the code that breaks with Python 3.5 or 3.6 and it's easy enough to support those versions, which is why I'm not removing support for them entirely yet. I also upgraded the workflow configuration from the beta version of Python 3.11 to the final release version.
diazona
force-pushed
the
fix-os-for-old-python-version/1/dev
branch
from
January 21, 2023 10:34
7f4f854 to
3c84ace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the Github Actions workflow configuration to use an older version of Ubuntu for testing on Python 3.5 and 3.6 - namely Ubuntu 20.04 instead of the current default 22.04. The runners that Github provides with Ubuntu 22.04 don't support versions of Python prior to 3.7.
We will remove support for Python <3.7 at some point, when a code change makes it necessary, but for now there happens to be nothing in the code that breaks with Python 3.5 or 3.6 and it's easy enough to support those versions, which is why I'm not removing support for them entirely yet.
I also upgraded the workflow configuration from the beta version of Python 3.11 to the final release version.
By merging this I hope to get all tests passing in #55.