Skip to content

Update syntax to Python 3 - #36

Merged
diazona merged 1 commit into
pytest-dev:masterfrom
hramezani:update_syntax
May 13, 2022
Merged

Update syntax to Python 3#36
diazona merged 1 commit into
pytest-dev:masterfrom
hramezani:update_syntax

Conversation

@hramezani

Copy link
Copy Markdown
Member

No description provided.

@hramezani hramezani mentioned this pull request May 9, 2022
@diazona

diazona commented May 10, 2022

Copy link
Copy Markdown
Contributor

Thanks, this makes sense. Let's give it a while and see what the other maintainers say, if they see this anytime soon.

The addition of the badges seems out of place in this pull request... personally I would have split that to a separate PR, but it's not a big deal.

Comment thread README.rst Outdated
@hramezani

Copy link
Copy Markdown
Member Author

The addition of the badges seems out of place in this pull request... personally I would have split that to a separate PR, but it's not a big deal.

As I keep it in a separate commit, I think you can merge the PR with a Rebase and Merge. Then we will have two separate commits.

@diazona

diazona commented May 10, 2022

Copy link
Copy Markdown
Contributor

As I keep it in a separate commit, I think you can merge the PR with a Rebase and Merge. Then we will have two separate commits.

Well, that wouldn't be consistent with the merge workflow we've been using. (Merge commits help keep track of features on master and keep the development history well organized.)

@hramezani hramezani changed the title Update syntax Update syntax to Python 3 May 10, 2022
@hramezani

Copy link
Copy Markdown
Member Author

@diazona I've removed the badges commit from this PR and created #38

@diazona
diazona merged commit a1a4601 into pytest-dev:master May 13, 2022

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommended trying shed/pyupgrade

@diazona diazona added this to the v0.7.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants