Remove redudant wheel dep from pyproject.toml - #34
Merged
Conversation
The `setuptools` PEP517 backend provides the dependency on `wheel` implicitly. The explicit dep is unnecessary and specifying it is no longer the recommended practice per setuptools documentation.
Contributor
|
pypa/setuptools#3056 for context Thanks for the fix! I want to give it a little while (probably a few days) in case the other maintainers have any comments, then I'll merge this. |
RonnyPfannschmidt
requested changes
May 6, 2022
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| requires = ["setuptools >=42", "setuptools_scm[toml] >=3.4.1", "wheel"] | |||
| requires = ["setuptools >=42", "setuptools_scm[toml] >=3.4.1"] | |||
Member
There was a problem hiding this comment.
i suspect a version pin increase for setuptools is also necessary, can we crosscheck
RonnyPfannschmidt
approved these changes
May 6, 2022
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
Member
There was a problem hiding this comment.
its been there from day on, so YAY
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
setuptoolsPEP517 backend provides the dependency onwheelimplicitly. The explicit dep is unnecessary and specifying it is
no longer the recommended practice per setuptools documentation.