Drop support for older Python versions - #25
Merged
Conversation
Merged
Contributor
Author
|
I pushed fixup commits to drop support for 3.3 as well, since I use enums in #21 and they were only added in 3.4. (And I'm kind of hesitant about supporting versions that aren't tested by the continuous integration script anyway) I figured we might as well do that at the same time as dropping Python 2 support. Happy to abandon those commits and keep support for 3.3 if anyone wants to argue for it, though. |
coordt
reviewed
Dec 12, 2021
coordt
reviewed
Dec 12, 2021
coordt
reviewed
Dec 12, 2021
diazona
force-pushed
the
drop-py2-support/1/dev
branch
from
December 12, 2021 22:01
c0b0e23 to
ea8f9e1
Compare
diazona
force-pushed
the
drop-py2-support/1/dev
branch
from
December 13, 2021 20:44
ea8f9e1 to
27dafd8
Compare
diazona
marked this pull request as ready for review
December 13, 2021 20:44
This commit removes the tox environments for Python 2.7, 3.3, and 3.4, since we no longer plan to officially support those versions.
This commit edits setup.py to require Python 3.5 or greater, and removes the trove classifiers for Pythons 2, 2.7, 3.3, and 3.4, while adding the classifier for Python 3 only.
diazona
force-pushed
the
drop-py2-support/1/dev
branch
from
December 13, 2021 20:50
27dafd8 to
d459d45
Compare
Contributor
Author
|
@coordt you mind giving a final sanity check? |
coordt
approved these changes
Dec 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #24 to drop support for Python 2, when we're ready for that.