Add support for Python 3.14 - #130
Merged
Merged
Conversation
Contributor
Author
|
Looks like there's a conflict between Python 3.14 and assertion rewriting in pytest 6.2.4. I'll track down a suitable minimum pytest version and update accordingly. |
diazona
marked this pull request as draft
November 9, 2025 04:43
diazona
force-pushed
the
python-3.14/1/dev
branch
from
November 9, 2025 09:32
c4cdbf9 to
5c76595
Compare
I had to set the minimum pytest version for Python 3.14 to pytest 7.3.2, because older versions of pytest use ast.Str, which was removed in 3.14.
diazona
force-pushed
the
python-3.14/1/dev
branch
from
November 9, 2025 09:37
5c76595 to
47904ad
Compare
The main purpose of this commit is to enable testing on Python 3.14 in CI. But Python 3.14 requires a different minimum version of pytest from any earlier version, meaning that we now have three different minimum pytest versions that need to be tested depending on the Python version, and that's very complicated to express by including and excluding specific configurations as we were doing before. So I refactored the matrix of versions to take advantage of the ability to have objects as matrix values, meaning that each Python version can be accompanied by the specific minimum pytest version it requires in the matrix. This is much easier to understand and maintain, and it should also have us running fewer CI jobs overall (since we're no longer going to run combinations like pytest 6.2.4 on Python 3.7-3.9, which served no purpose).
diazona
force-pushed
the
python-3.14/1/dev
branch
from
November 9, 2025 09:41
47904ad to
f68ce97
Compare
Contributor
Author
|
Got it working now 🎉 |
diazona
marked this pull request as ready for review
November 9, 2025 09:45
Pierre-Sassoulas
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds testing for Python 3.14 and adds it to the list of supported versions.
It's a bit overdue, but better late than never.