Remove PyTest command from setup.py - #124
Merged
Merged
Conversation
Now that direct execution of setup.py is deprecated, we shouldn't have a custom setuptools command to run tests. Testing the package can be done by running pytest directly, typically from within tox. Accordingly, I'm removing the PyTest command from setup.py in this commit.
RonnyPfannschmidt
approved these changes
Oct 25, 2025
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
Member
There was a problem hiding this comment.
looks good, consider going pyproject native and adopting setuptools_scm
Contributor
Author
|
We already do use I do have plans to shift more stuff into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that direct execution of
setup.pyis deprecated, we shouldn't have a custom setuptools command to run tests. Testing the package can be done by running pytest directly, typically from within tox. Accordingly, I'm removing thePyTestcommand fromsetup.pyin this commit.