Remove driver code - #119
Merged
Merged
Conversation
Since this package is meant to be installed and imported, it doesn't really make sense anymore to have code in the modules that allows those modules to be executed as individual Python scripts. So I'm removing that code in this commit. I considered adding tests to replicate the functionality of the code being removed, but there didn't seem to be much point. The removed code just does a basic check that the server can start and stop, and relies on some external client to send HTTP or SMTP requests, and our existing tests cover all that functionality already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this package is meant to be installed and imported, it doesn't really make sense anymore to have code in the modules that allows those modules to be executed as individual Python scripts. So I'm removing that code in this commit.
I considered adding tests to replicate the functionality of the code being removed, but there didn't seem to be much point. The removed code just does a basic check that the server can start and stop, and relies on some external client to send HTTP or SMTP requests, and our existing tests cover all that functionality already.