This repository was archived by the owner on Dec 23, 2024. It is now read-only.
Exclude tests from the distributed wheel#33
Open
SandaruKasa wants to merge 1 commit intopyrogram:masterfrom
Open
Exclude tests from the distributed wheel#33SandaruKasa wants to merge 1 commit intopyrogram:masterfrom
tests from the distributed wheel#33SandaruKasa wants to merge 1 commit intopyrogram:masterfrom
Conversation
SpEcHiDe
pushed a commit
to TelegramPlayground/pyrogram-tgcrypto
that referenced
this pull request
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I can tell, it is discouraged to have a top-level directory named
testsdistributed alongside with the package: https://wiki.archlinux.org/title/Python_package_guidelines#Test_directory_in_site-package So this PR excludes it from the final.whlbeing built.To the best of my understanding, it broke neither the deprecated
python3 setup.py test, not thetox, orpytest. However, it might have broken someone's code if it relied on tgcrypto being distributed alongside with the tests. In which case, WTF.Anyways, this most likely needs a version bump of some sorts, no matter the breakingness of the change.