locale aware defaultFilename timestamp formatting#117
Closed
victorhaggqvist wants to merge 1 commit intopynicolas:mainfrom
Closed
locale aware defaultFilename timestamp formatting#117victorhaggqvist wants to merge 1 commit intopynicolas:mainfrom
victorhaggqvist wants to merge 1 commit intopynicolas:mainfrom
Conversation
where from docs date SHORT is completely numeric (asside from formatting) time MEDIUM is time including seconds which looks to catch the intent behind the static format, but in locale aware formatting
Owner
|
Thanks for the PR and the explanation. Before discussing a solution, I'd like to better understand the underlying problem or user need this is addressing. The current format is intentionally explicit and stable, and changing it impacts more than just localization (ordering, separators, filename safety, predictability, etc.). So this is more of a product decision than a pure implementation detail. Could you open a GitHub issue to describe:
That would help clarify whether this should be changed. For now, I'd prefer to discuss the use case first before merging a solution. Thanks again for taking the time to contribute. |
Owner
|
See #118. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
defaultFilenamelocale aware in formatting.Where from docs
SHORTis completely numeric (aside from formatting)MEDIUMis time including secondsWhich looks to catch the intent behind the static format, but in locale aware formatting. Effectively, the date/time contents remain, but the punctuation and order of date/time parts localize.