Repository navigation
fix(shared): handle PR links for local filesystem remotes - #920
Merged
Merged
Conversation
…tion (#13463) Co-authored-by: Julius Marminge <julius0216@outlook.com> Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com> (cherry picked from commit 38f3c62304bfe79ea6c9f75a17afb732b555f48d)
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A thread with saved PR links and an absolute filesystem Git remote can throw during legacy PR-link projection because it has neither a provider nor a hostname. Return no legacy link when the resolved host is absent, leaving the modern link array intact.
Adopts every hunk of
38f3c62304bfe79ea6c9f75a17afb732b555f48d(T3 #13463), in the separately frozen successor inventory for #865. The source commit retains attribution; its new test uses Pylon's branded ProjectId constructor. The shared helper is called by metadata decisions, event projection and SQL snapshot reads. Those consumers serve web, desktop and mobile across local, remote and tunnel connections. Existing Azure and Forgejo routing is retained; no schema, migration or provider capability changes.Validation: the new regression fails before the fix with
TypeError: Cannot read properties of undefined (reading 'toLowerCase')and passes afterward. All 54 focused thread-PR and source-control tests pass, including Hermes array-method compatibility and Azure/Forgejo identities. Shared typecheck, scoped lint, format and diff checks pass. Lint reports one existing reverse-method warning on the intentionally retained Hermes-compatible implementation; typecheck reports existing Effect suggestions. No live server or client runtime was exercised.Related tracking: #865. Pending approved merge; original cycle bounds and cursor remain unchanged.
Model: GPT-6 (Codex). Harness: Codex in Pylon.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.