Repository navigation
fix(opencode): settle interrupted prompt admissions - #918
Merged
Merged
Conversation
Adapt T3 source e518866d28603da273a9357516dd1aef919f1353 (#12003). Capture the send-owned admission so finalization cannot settle another prompt.
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interrupted OpenCode turn admission can leave Stop waiting forever, holding up thread deletion and later thread creation. Complete the send-owned submission receipt on every exit, including interruption before the prompt worker starts.
Adapted source:
e518866d28603da273a9357516dd1aef919f1353(T3 #12003), in successor boundab099178a7b7f9728843e90fc95ed90bb61d710d..0fcd5f90611451cca842689faea53b5450c022da. Related tracking: #865. Its existing 127-source range and review cursor remain unchanged.Pylon captures this send's deferred rather than reading whichever admission is currently on the session. The finalizer runs inside the prompt permit; session incarnation, cancellation, recovery and remote-abort behavior remain in place. The existing prompt-worker finalizer still handles submitted prompts.
Validation: the gated regression times out before the fix and passes after it; it confirms no prompt was submitted and Stop removes the session and closes the runtime. All 135 OpenCode adapter tests pass, along with server typecheck (existing Effect suggestions only), scoped lint, format and diff checks. This is provider-local behavior shared by web, desktop and mobile in local, remote and tunnel modes; no wire schema, persistence migration, or other provider change. A real OpenCode process was not exercised. Independent PR review and final-head CI remain required before merge.
Model: GPT-6.1 Sol. Harness: Codex in Pylon.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.