Repository navigation
fix(acp): keep one answer through tool progress - #868
Merged
Merged
Conversation
Co-authored-by: adeebahmad01 <52380344+adeebahmad01@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit e759847f932c0de08261ec98a5fac3bae037120f)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP tool progress updates currently complete the active assistant item, which splits one streaming answer into separate items. This is visible when a background command reports progress while the agent is writing a markdown table.
Track recently shown tool-call IDs and close the assistant segment only for a newly shown tool. An active call remains recognized if its ID ages out of the bounded recent-ID cache; terminal and repeated updates keep their emitted tool state without splitting prose. The change selectively ports T3 source
e759847f932c0de08261ec98a5fac3bae037120f(#13386) into Pylon's ACP runtime, without changing wire contracts.Pylon's Prime adapter also used every tool update as a final-response boundary. It now consumes the ACP runtime's explicit boundary decision, so a background tool completing after the final text cannot cause a false missing-final-response warning. A new tool after text still resets that response state.
Focused validation on
3d4fa44c10e2957f3a7c086ef5e8633b123e2ab1:vp test run apps/server/src/provider/acp/AcpJsonRpcConnection.test.ts apps/server/src/provider/Layers/PrimeAgentAdapter.test.ts(27 passed),vp run --filter t3 typecheck, scopedvp lint, and scopedvp fmt --check. The regressions cover progress, completion, repeated completion, an active tool aged out after 256 later calls, and Prime settlement with no text after the background completion. The existing Prime tool-only test still checks the missing-final-response warning.Tracking: #865. Independent adversarial review and final-head CI remain pending.
Model: GPT-6 (Codex in Pylon harness).