Skip to content

feat(pair): keep the executor in step with its lead #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rynfar merged 6 commits into from
Sep 18, 2026
Merged

feat(pair): keep the executor in step with its lead #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d791b71
test(pair): contract and failing tests for the pair lifecycle
rynfar Sep 18, 2026
349243e
feat(pair): pure rules for what a lead's lifecycle means for its exec…
rynfar Sep 18, 2026
2df37c0
feat(pair): keep the executor in step with its lead
rynfar Sep 18, 2026
519b8b0
feat(pair): start the pair lifecycle reactor with the server
rynfar Sep 18, 2026
4e22745
feat(pair): do not reap an executor while its lead is mid-turn
rynfar Sep 18, 2026
9fa8cfc
docs(pair): make the lead protocol test-first and describe the pair l…
rynfar Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/server/integration/OrchestrationEngineHarness.integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ import {
import { ThreadDeletionReactor } from "../src/orchestration/Services/ThreadDeletionReactor.ts";
import * as ThreadSettlementReactor from "../src/orchestration/ThreadSettlementReactor.ts";
import * as DelegationFollowThroughReactor from "../src/orchestration/DelegationFollowThroughReactor.ts";
import * as PairLifecycleReactor from "../src/orchestration/PairLifecycleReactor.ts";
import * as PullRequestSyncReactor from "../src/orchestration/PullRequestSyncReactor.ts";
import * as ThreadPullRequestReactor from "../src/orchestration/ThreadPullRequestReactor.ts";
import * as ProjectSettingsReactor from "../src/orchestration/ProjectSettingsReactor.ts";
Expand Down Expand Up @@ -401,6 +402,12 @@ export const makeOrchestrationIntegrationHarness = (
drain: Effect.void,
}),
),
Layer.provide(
Layer.succeed(PairLifecycleReactor.PairLifecycleReactor, {
start: () => Effect.void,
drain: Effect.void,
}),
),
Layer.provideMerge(
Layer.succeed(ThreadSettlementReactor.ThreadSettlementReactor, {
start: () => Effect.void,
Expand Down
11 changes: 11 additions & 0 deletions apps/server/src/orchestration/Layers/OrchestrationReactor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { ProviderRuntimeIngestionService } from "../Services/ProviderRuntimeInge
import { ThreadDeletionReactor } from "../Services/ThreadDeletionReactor.ts";
import * as ThreadSettlementReactor from "../ThreadSettlementReactor.ts";
import * as DelegationFollowThroughReactor from "../DelegationFollowThroughReactor.ts";
import * as PairLifecycleReactor from "../PairLifecycleReactor.ts";
import * as PullRequestSyncReactor from "../PullRequestSyncReactor.ts";
import * as ProjectSettingsReactor from "../ProjectSettingsReactor.ts";
import * as ThreadPullRequestReactor from "../ThreadPullRequestReactor.ts";
Expand Down Expand Up @@ -96,6 +97,15 @@ describe("OrchestrationReactor", () => {
drain: Effect.void,
}),
),
Layer.provideMerge(
Layer.succeed(PairLifecycleReactor.PairLifecycleReactor, {
start: () =>
Effect.sync(() => {
started.push("pair-lifecycle");
}),
drain: Effect.void,
}),
),
Layer.provideMerge(
Layer.succeed(ThreadSettlementReactor.ThreadSettlementReactor, {
start: () => {
Expand Down Expand Up @@ -142,6 +152,7 @@ describe("OrchestrationReactor", () => {
"pull-request-sync-reactor",
"agent-awareness-relay",
"delegation-follow-through",
"pair-lifecycle",
]);

await Effect.runPromise(Scope.close(scope, Exit.void));
Expand Down
3 changes: 3 additions & 0 deletions apps/server/src/orchestration/Layers/OrchestrationReactor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { ProviderRuntimeIngestionService } from "../Services/ProviderRuntimeInge
import { ThreadDeletionReactor } from "../Services/ThreadDeletionReactor.ts";
import * as ThreadSettlementReactor from "../ThreadSettlementReactor.ts";
import * as DelegationFollowThroughReactor from "../DelegationFollowThroughReactor.ts";
import * as PairLifecycleReactor from "../PairLifecycleReactor.ts";
import * as PullRequestSyncReactor from "../PullRequestSyncReactor.ts";
import * as ProjectSettingsReactor from "../ProjectSettingsReactor.ts";
import * as ThreadPullRequestReactor from "../ThreadPullRequestReactor.ts";
Expand All @@ -23,6 +24,7 @@ export const makeOrchestrationReactor = Effect.gen(function* () {
const threadDeletionReactor = yield* ThreadDeletionReactor;
const delegationFollowThrough =
yield* DelegationFollowThroughReactor.DelegationFollowThroughReactor;
const pairLifecycle = yield* PairLifecycleReactor.PairLifecycleReactor;
const threadSettlementReactor = yield* ThreadSettlementReactor.ThreadSettlementReactor;
const pullRequestSyncReactor = yield* PullRequestSyncReactor.PullRequestSyncReactor;
const threadPullRequestReactor = yield* ThreadPullRequestReactor.ThreadPullRequestReactor;
Expand All @@ -40,6 +42,7 @@ export const makeOrchestrationReactor = Effect.gen(function* () {
yield* pullRequestSyncReactor.start();
yield* agentAwarenessRelay.start();
yield* delegationFollowThrough.start();
yield* pairLifecycle.start();
});

return {
Expand Down
Loading
Loading