Repository navigation
fix(delegation): observe completed children as completed and suppress bookkeeping rows - #623
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Delegated children whose turns complete before a server restart or the idle reaper were being observed as
interruptedbyDelegationFollowThroughReactorbecauseobserveDelegatedChildprioritized a stopped session status over terminal turn states. In addition, changed child observations at startup could trigger stale wake turns, and internal delegation bookkeeping activity rows (delegation.child-stateanddelegation.follow-through.delivered) were rendering as clutter in web and mobile work logs.What changed
observeDelegatedChild(apps/server/src/orchestration/delegationFollowThrough.logic.ts) so terminal turn states (completed,interrupted,error) take precedence over a session stopped afterwards by a restart or the idle reaper, matchingderiveDelegatedThreadState.DelegationFollowThroughReactor.tsto baseline any child observation whose notice key changed while the server was down (startupPass && work.liveChildId !== child.id), preventing historical turns from triggering stale wakes.delegation.child-stateanddelegation.follow-through.deliveredto the web work log skip list inapps/web/src/session-logic.ts, keeping reactor bookkeeping hidden while leaving the user-facingdelegation.follow-through.pausednotice visible.apps/mobile/src/lib/threadActivity.ts.docs/internals/delegation.md, and appended durable fact2026-09-18-delegation-follow-through-observationto.agents/durable-facts.jsonl.Verification
vp test run apps/server/src/orchestration/delegationFollowThrough.logic.test.ts: PASS (13 passed)vp test run apps/server/src/orchestration/DelegationFollowThroughReactor.test.ts: PASS (15 passed)vp run -F t3 typecheck: PASS (exit 0)vp test run apps/web/src/session-logic.test.ts: PASS (95 passed)vp run -F @t3tools/web typecheck: PASS (exit 0)vp test run apps/mobile/src/lib/threadActivity.test.ts: PASS (112 passed)vp run -F @t3tools/mobile typecheck: PASS (exit 0)vp fmt --check <modified files>: PASS (correct format)vp lint <modified code files>: PASS (0 errors, 0 warnings)origin/pylonfor prohibited files: PASS (empty diff)Not covered
No live provider runs; PR #620 files untouched.
Part of #622.
Planned and verified by Claude Fable 5.1 in Claude Code; implemented by Gemini 3.8 Flash (High) in Antigravity, as a Pylon delegated child.