Skip to content

Enable dynamic attribute support for Pypy >= 6#1494

Closed
inducer wants to merge 2 commits into
pybind:masterfrom
inducer:master
Closed

Enable dynamic attribute support for Pypy >= 6#1494
inducer wants to merge 2 commits into
pybind:masterfrom
inducer:master

Conversation

@inducer

@inducer inducer commented Aug 19, 2018

Copy link
Copy Markdown
Contributor

According to my experiments, the code that's disabled by the conditional on Pypy appears to work just fine on (at least) Pypy 6.0.

@wjakob

wjakob commented Aug 28, 2018

Copy link
Copy Markdown
Member

I'm hesitant to merge this if there is no test coverage. Would you mind adding a PyPy 6.x configuration to Travis?

@inducer

inducer commented Aug 28, 2018

Copy link
Copy Markdown
Contributor Author

Done. It does not pass, but the failures look largely unrelated to the change I made:

https://travis-ci.org/pybind/pybind11/jobs/421779974

@bstaletic

Copy link
Copy Markdown
Collaborator

Rebase onto master. The failure was fixed last night.

@inducer

inducer commented Aug 29, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for taking a look. Still failing, with much the same failures:

https://travis-ci.org/pybind/pybind11/jobs/421907230

@wjakob

wjakob commented Sep 11, 2018

Copy link
Copy Markdown
Member

hm :-| -- any thoughts on what the deal is with the other PyPy issue?

@inducer

inducer commented Sep 11, 2018

Copy link
Copy Markdown
Contributor Author

No clue, sorry.

@xuhdev

xuhdev commented Sep 19, 2018

Copy link
Copy Markdown

Do you have any actual reference that PyPy 6 has this enabled?

@wjakob

wjakob commented Sep 19, 2018

Copy link
Copy Markdown
Member

Not sure I understand, what does "this" refer to in your sentence? Attribute support?

@xuhdev

xuhdev commented Sep 19, 2018

Copy link
Copy Markdown

@wjakob Yes... sorry for the confusion.

lopuhin added a commit to lopuhin/pybind11 that referenced this pull request Mar 3, 2019
lopuhin added a commit to lopuhin/pybind11 that referenced this pull request Mar 8, 2019
lopuhin added a commit to lopuhin/pybind11 that referenced this pull request Mar 8, 2019
lopuhin added a commit to lopuhin/pybind11 that referenced this pull request Mar 8, 2019
@isuruf isuruf mentioned this pull request Mar 26, 2020
2 tasks
@rwgk

rwgk commented Jun 18, 2020

Copy link
Copy Markdown
Collaborator

Hi Andreas, there was a recent upgrade to use PyPy 7.3 on travis, e.g. here is a random recent result (bottom of page): https://travis-ci.org/github/pybind/pybind11/builds/698654908
Is this PR still relevant?

@lopuhin

lopuhin commented Jun 18, 2020

Copy link
Copy Markdown

@rwgk I think this PR is still relevant and now it seems closer to merging (after travis changes are removed), as these changes https://github.com/pybind/pybind11/pull/1494/files#diff-cb87ad4a7288c536c9adc5a5694134ca still look relevant to me.

@inducer

inducer commented Jun 18, 2020

Copy link
Copy Markdown
Contributor Author

IMO, #2146 by @isuruf supersedes this. I contains this change (and adds a related test). I'm happy to close this as long as there's a chance that #2146 will get merged.

@wjakob

wjakob commented Jun 30, 2020

Copy link
Copy Markdown
Member

It will be merged soon, I will close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants