BUG: Reject an odd-length print page range - #4013
Merged
stefan6419846 merged 1 commit intoAug 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4013 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 57 57
Lines 11122 11124 +2
Branches 2085 2086 +1
=======================================
+ Hits 10900 10902 +2
Misses 124 124
Partials 98 98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
requested changes
Aug 26, 2026
stefan6419846
left a comment
stefan6419846
left a comment
Collaborator
There was a problem hiding this comment.
Please resolve the merge conflicts.
/PrintPageRange holds first/last page pairs, so an array with an odd number of entries leaves a range without its end. It was written through unchecked. The check is limited to that key because _set_arr is shared with /Enforce, which has no such constraint.
RavSinghChandan
force-pushed
the
validate-print-pagerange
branch
from
August 26, 2026 10:07
86d6f3c to
8d89881
Compare
Contributor
Author
|
Rebased onto main. |
stefan6419846
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/PrintPageRangeholds first/last page pairs, as the viewer preferences documentation shows:An array with an odd number of entries leaves a range without its end, and was written through unchecked.
The check is limited to that key because
_set_arris shared with/Enforce, which has no such constraint. An empty array stays valid.Reverting the change fails the two new tests