make test_forecast.py more robust, warn problems instead of fail#522
Merged
wholmgren merged 2 commits intopvlib:masterfrom Aug 7, 2018
Merged
make test_forecast.py more robust, warn problems instead of fail#522wholmgren merged 2 commits intopvlib:masterfrom
wholmgren merged 2 commits intopvlib:masterfrom
Conversation
Member
Author
|
Example of printed warning instead of a fail: https://travis-ci.org/pvlib/pvlib-python/jobs/412887886 |
cwhanse
approved these changes
Aug 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.git diff upstream/master -u -- "*.py" | flake8 --diffBrief description of the problem and proposed solution (if not already fully described in the issue linked to above):
This PR should resolve the majority of the intermittent test failures due to
test_forecast.py. The errors will now be recorded as warnings. This is not ideal but I think it's acceptable.I tested that all of the warnings are printed when I force exceptions in the try blocks.