[WIP] relax Data.String.CodeUnits.slice + related changes as per #143#145
Merged
thomashoneyman merged 3 commits intopurescript:masterfrom Mar 25, 2022
Quelklef:master
Merged
[WIP] relax Data.String.CodeUnits.slice + related changes as per #143#145thomashoneyman merged 3 commits intopurescript:masterfrom Quelklef:master
thomashoneyman merged 3 commits intopurescript:masterfrom
Quelklef:master
Conversation
…be` in return type
JordanMartinez
added
purs-0.15
Contributor
thomashoneyman
approved these changes
Mar 25, 2022
thomashoneyman
approved these changes
Mar 25, 2022
Contributor
Author
|
Hey, I think this is my very first open-source contribution! Cheers all 🥂 |
Member
|
@Quelklef Congrats! 🎉 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR closes #143.
That issue originally was about changing the bounds checking of
Data.String.CodeUntis.slice. It has since been decided that the appropriate fix is to remove bounds checking altogether and to change the type fromInt -> Int -> Maybe StringtoInt -> Int -> String.Additionally, there is discussion in that ticket about improving similar string-and-index operations to be more consistent with the API. Hence the WIP-ness of this PR, so that those additional changes can be added as they are pointed out.
Checklist: